New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use condition and notification placeholders #3432

Merged
merged 2 commits into from Jan 26, 2017

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Jan 26, 2017

When condition or notification titles are not set, use placeholders instead of not showing anything at all.

These changes also make use of notification titles. They were introduced quite late and we forgot to modify the AlertTimeline component with that.

Fixes #3429

edmundoa added some commits Jan 26, 2017

Show notification placeholder title when not set
Also use the notification title in the alarm callback history if it was
set.

@edmundoa edmundoa added this to the 2.2.0 milestone Jan 26, 2017

@kroepke kroepke self-assigned this Jan 26, 2017

@kroepke

lgtm

@kroepke kroepke merged commit 33ed46f into master Jan 26, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1325 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@kroepke kroepke deleted the issue-3429 branch Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment