Use consistent case in old message count conditions #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 1, 2017 15:48
Since 2.2.0, we are storing the message count `threshold_type` parameter in uppercase, just like we do with other types in field value conditions. Previous Graylog versions were storing `threshold_type` in lowercase, same case that were use in parameters when instantiating new MessageCountAlertCondition objects. This resulted in case inconsistencies in objects from that class, which were propagated to the API and persistance layer. This commit converts `threshold_type` to uppercase, so we use that case when instantiating old conditions. Fixes #3451
bernd
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.2.0, we are storing the message count
threshold_typeparameter in upper case, just like we do with other types in field value conditions. Previous Graylog versions were storingthreshold_typein lower case, same case that were use in parameters when instantiating newMessageCountAlertConditionobjects. This resulted in case inconsistencies in objects from that class, which were propagated to the API and persistence layer.This PR converts
threshold_typeto upper case, so we use that case when instantiating old conditions. I also included two other related small fixes: using consistent case in alert condition descriptions, and fixing theoptionkeys inDropdownFields. Let me know if I crept too much in here 馃槈Fixes #3451