New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Query Button Fix (#3491) #3548

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@billmurrin
Contributor

billmurrin commented Feb 26, 2017

Description

Changes behavior of ClipboardButton component to rely on the target instead of passing in text. For some reason, passing in text, does not cause the text to be copied to the clipboard. However, passing in target element does cause ClipBoard to work properly. This is related to bug report #3491.

Motivation and Context

Fixes open issue #3491 which allows queries to be copied to the clipboard.

How Has This Been Tested?

I test changes by running the web interface with the change. The changes worked as expected. I also did in depth troubleshooting on the text portion and do not understand the reason that it is not copying.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dennisoelkers dennisoelkers self-assigned this Feb 27, 2017

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Mar 9, 2017

Works perfect on all tested browsers.

@dennisoelkers dennisoelkers merged commit a273393 into Graylog2:master Mar 9, 2017

3 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1386 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

dennisoelkers added a commit that referenced this pull request Mar 9, 2017

edmundoa added a commit that referenced this pull request Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment