Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Escaping username/roles parameters to allow usernames/roles with special characters. #3570
Motivation and Context
Before this change it was possible to create user/role names containing one or more slashes or other special characters, but it was not possible to delete them afterwards from the web interface.
After this change, the user/role name used to construct the URL to the backend is escaped properly, so deletions suceed even if the user/role name contains one or more special characters.
Fixes #3569. Should also be merged into
Types of changes
changed the title from
Escaping username component to allow usernames with slash.
Escaping username/roles parameters to allow usernames/roles with special characters.
Mar 6, 2017
I totally understand your question and had the same idea at first. Unfortunately we cannot do it that way, because we also use those routes to generate the route map for our application and reuse the parameters with placeholders (
There still seem to be some places missing.
For example I'm unable to log in with a user named "foo/bar".
The Chrome Console shows the following error message:
There was an error fetching a resource: cannot GET http://127.0.0.1:9000/api/users/foo/bar (404). Additional information: HTTP 404 Not Found
Unhandled rejection Error: cannot GET http://127.0.0.1:9000/api/users/foo/bar (404)