New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloning alert conditions with identical id when cloning stream. #3616

Merged
merged 2 commits into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Mar 15, 2017

Before this change, any alert conditions associated with a stream were
cloned identically (including using the same id) when cloning a stream.
This was leading to a bug, where the alert condition was shown as being
associated with the source of the clone process instead of the target.

With this change, the alert condition is recreated during cloning,
including generating a new id for it.

Fixes #3608.

(cherry picked from commit 0a9f75b)

Fix cloning alert conditions with identical id when cloning stream.
Before this change, any alert conditions associated with a stream were
cloned identically (including using the same id) when cloning a stream.
This was leading to a bug, where the alert condition was shown as being
associated with the source of the clone process instead of the target.

With this change, the alert condition is recreated during cloning,
including generating a new id for it.

Fixes #3608.

(cherry picked from commit 0a9f75b)

@dennisoelkers dennisoelkers added the bug label Mar 15, 2017

@dennisoelkers dennisoelkers added this to the 2.2.3 milestone Mar 15, 2017

@joschi joschi self-assigned this Mar 16, 2017

@joschi

joschi approved these changes Mar 16, 2017

LGTM. 👍

@joschi

joschi approved these changes Mar 16, 2017

LGTM. 👍

@joschi joschi merged commit 8c90d09 into 2.2 Mar 16, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1448 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@joschi joschi deleted the issue-3608-on-2.2 branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment