New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC for embedded Date objects as well #3626

Merged
merged 1 commit into from Mar 17, 2017

Conversation

Projects
None yet
3 participants
@bernd
Member

bernd commented Mar 16, 2017

The MongoDB driver creates Date objects when deserializing documents from the database. Without this, the converted DateTime object's time zone would depend on the JVM default zone.

We do the same in the MongoZonedDateTimeDeserializer.

This should be back-ported into 2.2.

Use UTC for embedded Date objects as well
The MongoDB driver creates Date objects when deserializing documents
from the database. Without this, the converted DateTime object's time
zone would depend on the JVM default zone.

@bernd bernd added this to the 2.3.0 milestone Mar 16, 2017

@bernd bernd requested review from joschi and kroepke Mar 16, 2017

@kroepke

Looks good to me, we always write with UTC to the database, so this should be safe.

@joschi

joschi approved these changes Mar 17, 2017

@joschi joschi merged commit 3f6543b into master Mar 17, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1455 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@joschi joschi self-assigned this Mar 17, 2017

@joschi joschi deleted the fix-mongo-datetime-deser branch Mar 17, 2017

joschi added a commit that referenced this pull request Mar 17, 2017

Use UTC for embedded Date objects as well (#3626)
The MongoDB driver creates Date objects when deserializing documents
from the database. Without this, the converted DateTime object's time
zone would depend on the JVM default zone.
(cherry picked from commit 3f6543b)

kroepke added a commit that referenced this pull request Mar 17, 2017

Use UTC for embedded Date objects as well (#3626) (#3631)
The MongoDB driver creates Date objects when deserializing documents
from the database. Without this, the converted DateTime object's time
zone would depend on the JVM default zone.
(cherry picked from commit 3f6543b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment