Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent session extension for polling system messages #3632

Merged
merged 1 commit into from Mar 17, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Mar 17, 2017

Fixes #3628

@joschi joschi added this to the 2.3.0 milestone Mar 17, 2017
@joschi
Copy link
Contributor Author

@joschi joschi commented Mar 17, 2017

This has to be back-ported to the 2.2 branch once it has been reviewed and merged.

@edmundoa edmundoa self-assigned this Mar 17, 2017
Copy link
Member

@edmundoa edmundoa left a comment

I'm kind of undecided about this change: on one hand it fixes the problem when the user does not interact with the system messages, but on the other it does not extend the session when the user is moving through the pages.

I guess the main problem is that we use this action both in automatic poll and when a manual interaction occurs (and that's not the case for other actions where we use fetchPeriodically, I think). Any ideas if there's a better way we can fix this?

@joschi
Copy link
Contributor Author

@joschi joschi commented Mar 17, 2017

but on the other it does not extend the session when the user is moving through the pages.

It's rather unlikely that a user will only click through the system messages related functionality for 15 minutes (or however long the session timeout is), so I guess this will not be a problem in practice.

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Mar 17, 2017

Yes, you are probably right. Still, in that case, it's safer to invalidate the session as to leave it open forever as it was before.

Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit 41be168 into master Mar 17, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1458 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-3628 branch Mar 17, 2017
edmundoa added a commit that referenced this pull request Mar 17, 2017
joschi added a commit that referenced this pull request Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants