New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore removal of role permissions upon permissions update. #3683

Merged
merged 1 commit into from Apr 3, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Apr 3, 2017

In #2529, while fixing #2516, persisting self editing permissions of a user was reintroduced (fixed in
35c9325 before). This happened due to the introduction of a temporary variable that was not used effctively.

After this change, LDAP permissions are not modified blindly but the permission set of a user still stays denormalized when modified and saved.

Restore removal of role permissions upon roles update.
In #2529, while fixing #2516, persisting all permissions of roles
assigned to a user was reintroduced (fixed in
35c9325 before). This happened due to
the introduction of a temporary variable that was not used effctively.

After this change, LDAP permissions are not modified blindly but the
permission set of a user still stays denormalized when modified and
saved.

@dennisoelkers dennisoelkers added this to the 2.3.0 milestone Apr 3, 2017

@dennisoelkers dennisoelkers changed the title from Restore removal of role permissions upon roles update. to Restore removal of role permissions upon permissions update. Apr 3, 2017

@kroepke

kroepke approved these changes Apr 3, 2017

@kroepke kroepke merged commit ffdbdda into master Apr 3, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1492 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@kroepke kroepke deleted the fix-not-storing-role-permissions-on-update branch Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment