Restore removal of role permissions upon permissions update. #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #2529, while fixing #2516, persisting all permissions of roles assigned to a user was reintroduced (fixed in 35c9325 before). This happened due to the introduction of a temporary variable that was not used effctively. After this change, LDAP permissions are not modified blindly but the permission set of a user still stays denormalized when modified and saved.
dennisoelkers
changed the title
kroepke
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2529, while fixing #2516, persisting self editing permissions of a user was reintroduced (fixed in
35c9325 before). This happened due to the introduction of a temporary variable that was not used effctively.
After this change, LDAP permissions are not modified blindly but the permission set of a user still stays denormalized when modified and saved.