New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated rotation/retention resources #3724

Merged
merged 2 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Apr 21, 2017

The rotation and retention strategies have been part of index sets since Graylog 2.2.0.

This change set removes the otherwise useless RotationStrategyResource and RetentionStrategyResource classes.

Refs #3722

Remove deprecated rotation/retention resources
The rotation and retention strategies are part of index sets since Graylog 2.2.0.

This change set removes the otherwise useless RotationStrategyResource and RetentionStrategyResource
classes.

Refs #3722

@joschi joschi added this to the 2.3.0 milestone Apr 21, 2017

@bernd bernd self-assigned this Apr 24, 2017

@bernd

Please note the resource removal in the UPGRADING.rst file. (that file needs to be truncated for 2.3)

@bernd

bernd approved these changes Apr 27, 2017

@bernd

This comment has been minimized.

Member

bernd commented Apr 27, 2017

LGTM 👍, thanks!

@bernd bernd merged commit effab18 into master Apr 27, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1513 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the remove-deprecated-rotation-retention-resources branch Apr 27, 2017

@bernd bernd removed the ready-for-review label Apr 27, 2017

bernd added a commit that referenced this pull request May 4, 2017

Revert parts of #3724 to unbreak editing index sets
The list of available rotation/retention strategies is still needed.

joschi added a commit that referenced this pull request May 4, 2017

Revert parts of #3724 to unbreak editing index sets (#3770)
* Revert parts of #3724 to unbreak editing index sets

The list of available rotation/retention strategies is still needed.

* Remove rotation/retention config actions from IndicesConfigurationStore

kroepke added a commit that referenced this pull request May 5, 2017

Revert parts of #3724 to unbreak editing index sets (#3770)
* Revert parts of #3724 to unbreak editing index sets

The list of available rotation/retention strategies is still needed.

* Remove rotation/retention config actions from IndicesConfigurationStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment