New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SearchPage "Updating..." Overlay Logic #3738

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
3 participants
@billmurrin
Contributor

billmurrin commented Apr 27, 2017

Description

Added conditional logic to SearchPage so that the updating overlay will not be shown if the auto-refresh is enabled and the update interval is 5 seconds or less. This issues is referenced in #3723

Motivation and Context

Change resolves reported issues in #3723

How Has This Been Tested?

Compiled graylog2-server from source and ran. Tested changes in web browser and monitored debug feedback. Changes were not observed affecting other areas of code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@edmundoa edmundoa self-assigned this Apr 27, 2017

@joschi joschi assigned joschi and unassigned edmundoa May 11, 2017

@joschi joschi added this to the 2.3.0 milestone May 11, 2017

@joschi

joschi approved these changes May 11, 2017

LGTM. 👍
Thanks, @billmurrin!

@joschi joschi merged commit 03b94cf into Graylog2:master May 11, 2017

3 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1533 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment