New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload errorstates on pages that don't need them #3839

Merged
merged 2 commits into from May 17, 2017

Conversation

Projects
2 participants
@kroepke
Member

kroepke commented May 17, 2017

Only schedule the error states reloading for overview pages.

fixes #3834

kroepke added some commits May 17, 2017

refactor error states timer handling to prevent unnecessary reloads
previously the page component always reloaded the error states even though
they were not used at all.

now the component only starts the timer for the overview pages

fixes #3834
make sure we don't accidentally leak background tasks
before scheduling a new interval make sure there's nothing running anymore

@kroepke kroepke added this to the 2.3.0 milestone May 17, 2017

@edmundoa edmundoa self-assigned this May 17, 2017

@edmundoa edmundoa self-requested a review May 17, 2017

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit 225157b into master May 17, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1652 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 133 has succeeded
Details

@edmundoa edmundoa deleted the issue-3834 branch May 17, 2017

@kroepke kroepke added this to Done in Lookup Tables May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment