New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Elasticsearch version when creating index template #3862

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented May 23, 2017

Instead of using a static configuration setting or trying to discover the Elasticsearch version
on startup (which might fail if Elasticsearch is unavailable), Graylog now checks the Elasticsearch
version when trying to create an index template and select the correct index mapping.

The "ping" request of Elasticsearch should be simple enough to not negatively influence the
Elasticsearch cluster and small enough to tolerate the additional network roundtrip.

This will fail if Elasticsearch is unavailable, but so would creating the index template.

Check Elasticsearch version when creating index template
Instead of using a static configuration setting or trying to discover the Elasticsearch version
on startup (which might fail if Elasticsearch is unavailable), Graylog now checks the Elasticsearch
version when trying to create an index template and select the correct index mapping.

The "ping" request of Elasticsearch should be simple enough to not negatively influence the
Elasticsearch cluster and small enough to tolerate the additional network roundtrip.

This will fail if Elasticsearch is unavailable, but so would creating the index template.

@joschi joschi added this to the 2.3.0 milestone May 23, 2017

@joschi joschi requested a review from dennisoelkers May 23, 2017

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented May 23, 2017

Could you please create a PR in the documentation repo reflecting the changes? Other than that: LGTM.

joschi added a commit to Graylog2/documentation that referenced this pull request May 23, 2017

@dennisoelkers dennisoelkers merged commit 19d98db into master May 24, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1662 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 143 has succeeded
Details

dennisoelkers added a commit to Graylog2/documentation that referenced this pull request May 24, 2017

@dennisoelkers dennisoelkers deleted the discover-elasticsearch-version branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment