Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup auto.offset.reset setting code in Kafka transport #3894

Merged
merged 1 commit into from Jun 9, 2017
Merged

Conversation

@bernd
Copy link
Member

@bernd bernd commented Jun 7, 2017

  • Convert to a DropdownField because there are only two valid values
  • Make sure to use the default if the config does not contain the
    setting yet (old inputs)

Refs #3743

/cc @r4um

- Convert to a DropdownField because there are only two valid values
- Make sure to use the default if the config does not contain the
  setting yet (old inputs)

Refs #3743
@bernd bernd added this to the 2.3.0 milestone Jun 7, 2017
@kroepke
kroepke approved these changes Jun 9, 2017
Copy link
Member

@kroepke kroepke left a comment

lgtm

@kroepke kroepke merged commit af43c1a into master Jun 9, 2017
4 checks passed
4 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 1694 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 169 has succeeded
Details
@kroepke kroepke deleted the cleanup-3743 branch Jun 9, 2017
@r4um
Copy link
Contributor

@r4um r4um commented Jun 19, 2017

FYI these values will change again when moving to consumer >=0.10.x.x, are called latest, earliest, none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.