Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for updating extractors in InputService #3910

Merged
merged 2 commits into from Jun 22, 2017
Merged

Add support for updating extractors in InputService #3910

merged 2 commits into from Jun 22, 2017

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jun 13, 2017

Instead of calling InputService#deleteExtractor() followed by InputService#addExtractor(),
which also emits the InputUpdated event twice, the InputService#updateExtractor() method
replaces the extractor in the embedded document in the "inputs" collection in MongoDB and
only emits the InputUpdated event once, which hopefully resolves the race condition described
in #3903.

Fixes #3903

@joschi joschi added this to the 2.3.0 milestone Jun 13, 2017
@bernd bernd self-assigned this Jun 21, 2017
Copy link
Member

@bernd bernd left a comment

I think we should have the #updateExtractor() method, that's fine. In addition, I think we should introduce a ExtractorUpdated event type. There is no reason to restart the input just because we updated an extractor. The ExtractorFilter should then listen on that new event.

Jochen Schalanda added 2 commits Jun 21, 2017
Instead of calling `InputService#deleteExtractor()` followed by `InputService#addExtractor()`,
which also emits the `InputUpdated` event twice, the `InputService#updateExtractor()` method
replaces the extractir un the  embedded document in the "inputs" collection in MongoDB and
only emits the `InputUpdated` event once, which hopefully resolves the race condition described
in #3903.

Fixes #3903
bernd
bernd approved these changes Jun 22, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit b9c7910 into master Jun 22, 2017
4 checks passed
@bernd bernd deleted the issue-3903 branch Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants