New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove link placement on tag-remove elements #3911

Merged
merged 2 commits into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@edmundoa
Member

edmundoa commented Jun 14, 2017

Just a small fix of something I saw in the new filter used in the collector plugin.

@edmundoa edmundoa added this to the 2.3.0 milestone Jun 14, 2017

@mariussturm

This comment has been minimized.

Member

mariussturm commented Jun 14, 2017

Works on all browsers but Chrome stable 59 (Version 59.0.3071.86 (Official Build) (64-bit)).
The 'X' is a little bit over the middle line of the text.

@edmundoa edmundoa removed this from the 2.3.0 milestone Jun 21, 2017

@edmundoa

This comment has been minimized.

Member

edmundoa commented Jun 21, 2017

As the change looks good in Chrome Canary, we are waiting a bit to see if the next Chrome version is not showing that issue. Otherwise we will work the PR a bit and try to fix the placement on all browsers.

@bernd bernd modified the milestone: 2.4.0 Jul 18, 2017

@bernd

This comment has been minimized.

Member

bernd commented Sep 11, 2017

@edmundoa @mariussturm Any progress on this?

@bernd

This comment has been minimized.

Member

bernd commented Sep 18, 2017

@edmundoa

This comment has been minimized.

Member

edmundoa commented Sep 18, 2017

@bernd @mariussturm this is looking good for me in Chrome 61.0.3163.91, so I think we can look into it again.

@bernd

This comment has been minimized.

Member

bernd commented Sep 18, 2017

@edmundoa Thank you!

@edmundoa edmundoa force-pushed the css-fix-remove-link branch from ab72270 to 7e33a0e Sep 18, 2017

Simplify style to fix tag-remove link placement
That seems to solve the issue still present in Chrome for Linux.
@edmundoa

This comment has been minimized.

Member

edmundoa commented Sep 18, 2017

@mariussturm I think the latest code should fix the issue you were still seeing in Chrome for Linux. Please take a look and let me know if it still looks odd!

@mariussturm mariussturm merged commit 87b651f into master Sep 20, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1919 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 464 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the css-fix-remove-link branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment