New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RoleResponse to java.util.Optional to fix serialization #3915

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Jun 14, 2017

This fixes a StackOverflowError when accessing the /roles API endpoint. It looks like the guava Optional class cannot be serialized by jackson.

Fixes #3913

Switch RoleResponse to java.util.Optional to fix serialization
This fixes a StackOverflowError when accessing the /roles API endpoint.
It looks like the guava Optional class cannot be serialized by jackson.

Fixes #3913

@bernd bernd added this to the 2.3.0 milestone Jun 14, 2017

@bernd bernd requested a review from edmundoa Jun 14, 2017

@edmundoa edmundoa self-assigned this Jun 15, 2017

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit 6dfb1b1 into master Jun 19, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1746 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 234 has succeeded
Details

@edmundoa edmundoa deleted the issue-3913 branch Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment