New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrying bulk indexing in case of all IOExceptions and failed http response. #3929

Merged
merged 2 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jun 22, 2017

This change modifies the retrying semantics of bulk indexing to trigger retries also if the request failed on an http level (result.isSucceeded() is false) or in case of an IOException which is not a SocketTimeoutException in case of a repeated attempt.

Created in response to the discussions in #3927.

Retrying in case of all IOExceptions and failed http response.
This change modifies the retrying semantics of bulk indexing to trigger
retries also if the request failed on an http level
(`result.isSucceeded()` is `false`) or in case of an `IOException` which
is not a `SocketTimeoutException` in case of a repeated attempt.

@dennisoelkers dennisoelkers added this to the 2.3.0 milestone Jun 22, 2017

@bernd bernd self-assigned this Jun 23, 2017

@bernd

bernd approved these changes Jun 23, 2017

LGTM 👍

@bernd bernd merged commit e37633a into master Jun 23, 2017

3 of 4 checks passed

graylog-project/pr Jenkins build graylog-project-pr-snapshot 275 has failed
Details
ci-web-linter Jenkins build graylog-pr-linter-check 1777 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the retry-bulk-index-in-case-of-http-errors branch Jun 23, 2017

@bernd bernd removed the ready-for-review label Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment