Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not retrying in case of isSuccessful() being false. #3941

Merged
merged 4 commits into from Jun 26, 2017

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jun 26, 2017

If isSuccessful() returns false for a bulk indexing result, retrying
the whole bulk will lead to infinite loops in case of index mapping
errors or other permanent errors.

This change also adds an informational logging message whenever a bulk
was indexed successfully on the n-th (n > 1) attempt, indicating that
indexing has recovered from a formerly erroneous condition.

Fixes #3938.

If `isSuccessful()` returns false for a bulk indexing result, retrying
the whole bulk will lead to infinite loops in case of index mapping
errors or other permanent errors.

This change also adds an informational logging message whenever a bulk
was indexed successfully on the n-th (n > 1) attempt, indicating that
indexing has recovered from a formerly erroneous condition.

Fixes #3938.
@dennisoelkers
Copy link
Member Author

@dennisoelkers dennisoelkers commented Jun 26, 2017

Wait before merging, I am adding tests.

@bernd
bernd approved these changes Jun 26, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd self-assigned this Jun 26, 2017
@bernd bernd merged commit f5f8f0d into master Jun 26, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1785 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 283 has succeeded
Details
@bernd bernd deleted the no-http-success-check-for-bulk-indexing branch Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants