Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Message class as not thread-safe #3978

Merged
merged 1 commit into from Jul 4, 2017
Merged

Mark Message class as not thread-safe #3978

merged 1 commit into from Jul 4, 2017

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jul 4, 2017

The Message class is not thread-safe and shouldn't be concurrently modified (i. e. Message#addField(…)).

This PR doesn't solve that problem, but it at least marks the class as not thread-safe to begin with.

Refs #3876

Jochen Schalanda
Refs #3876
@joschi joschi added this to the 2.3.0 milestone Jul 4, 2017
@joschi joschi requested a review from bernd Jul 4, 2017
@bernd
bernd approved these changes Jul 4, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 20b38d2 into master Jul 4, 2017
4 checks passed
4 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 1797 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 303 has succeeded
Details
@bernd bernd deleted the issue-3876 branch Jul 4, 2017
@bernd bernd removed the ready-for-review label Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.