Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry handling for failed Elasticsearch requests #4012

Merged
merged 1 commit into from Jul 17, 2017
Merged

Add retry handling for failed Elasticsearch requests #4012

merged 1 commit into from Jul 17, 2017

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jul 17, 2017

Jest now retries failed Elasticsearch requests a configurable number of times (default: 2)
until it gives up.

Unfortunately, the retry implementations in Apache Http Client via HttpRequestRetryHandler
couldn't be used because they don't allow changing the request (or at least the request URI)
between retries which is necessary to use all configured servers in the server pool.

Refs #4002, Fixes #3993

(cherry picked from commit 5ea9428)

Jest now retries failed Elasticsearch requests a configurable number of times (default: 2)
until it gives up.

Unfortunately, the retry implementations in Apache Http Client via `HttpRequestRetryHandler`
couldn't be used because they don't allow changing the request (or at least the request URI)
between retries which is necessary to use all configured servers in the server pool.

Fixes #3993

(cherry picked from commit 5ea9428)
@bernd
bernd approved these changes Jul 17, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 8fe29b7 into 2.3 Jul 17, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1814 has succeeded
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 324 has succeeded
Details
@bernd bernd deleted the pr-4002-2.3 branch Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants