Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Updating web dependencies. #4037
Running the production build with plugins is not currently working, I guess plugins also need some adjustments for this to work:
[INFO] Running 'npm run build' in /Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget [INFO] [INFO] > MapWidget@2.3.0-SNAPSHOT build /Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget [INFO] > webpack --bail [INFO] [ERROR] module.js:471 [ERROR] throw err; [ERROR] ^ [ERROR] [ERROR] Error: Cannot find module 'webpack' [ERROR] at Function.Module._resolveFilename (module.js:469:15) [ERROR] at Function.Module._load (module.js:417:25) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at Object.<anonymous> (/Users/edmundoa/Workspace/graylog/project/master/graylog2-server/graylog2-web-interface/webpack.config.js:2:17) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10) [ERROR] at Module.load (module.js:487:32) [ERROR] at tryModuleLoad (module.js:446:12) [ERROR] at Function.Module._load (module.js:438:3) [ERROR] at Module.require (module.js:497:17) [ERROR] at require (internal/module.js:20:19) [ERROR] at new PluginWebpackConfig (/Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget/node_modules/graylog-web-plugin/lib/PluginWebpackConfig.js:25:28) [ERROR] at Object.<anonymous> (/Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget/webpack.config.js:5:18) [ERROR] at Module._compile (module.js:570:32) [ERROR] at Object.Module._extensions..js (module.js:579:10)
After disabling plugins I didn't notice anything odd, so I guess we just need to adapt the plugin configuration for these changes. In my opinion we should do PRs for that and merge everything once it's ready. Otherwise the build is going to be broken for a while and that's far from optimal.
@dennisoelkers I'm quite sure I tried cleaning all node modules when it didn't work the first time. In any case today I tried again a couple times (after a local rebase) and it worked without any issues
Could you please update the
vendor-module-ids.json file reflecting the changes in here? Other than that I'm ready to merge.