New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating web dependencies. #4037

Merged
merged 6 commits into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jul 27, 2017

  • Updated webpack + loaders
  • Updated typescript + loader
    • Removed static checkins of declaration files
    • Replaced them with @types packages
  • Updated ESLint + configs from 3.x to 4.x
@edmundoa

Running the production build with plugins is not currently working, I guess plugins also need some adjustments for this to work:

[INFO] Running 'npm run build' in /Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget
[INFO] 
[INFO] > MapWidget@2.3.0-SNAPSHOT build /Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget
[INFO] > webpack --bail
[INFO] 
[ERROR] module.js:471
[ERROR]     throw err;
[ERROR]     ^
[ERROR] 
[ERROR] Error: Cannot find module 'webpack'
[ERROR]     at Function.Module._resolveFilename (module.js:469:15)
[ERROR]     at Function.Module._load (module.js:417:25)
[ERROR]     at Module.require (module.js:497:17)
[ERROR]     at require (internal/module.js:20:19)
[ERROR]     at Object.<anonymous> (/Users/edmundoa/Workspace/graylog/project/master/graylog2-server/graylog2-web-interface/webpack.config.js:2:17)
[ERROR]     at Module._compile (module.js:570:32)
[ERROR]     at Object.Module._extensions..js (module.js:579:10)
[ERROR]     at Module.load (module.js:487:32)
[ERROR]     at tryModuleLoad (module.js:446:12)
[ERROR]     at Function.Module._load (module.js:438:3)
[ERROR]     at Module.require (module.js:497:17)
[ERROR]     at require (internal/module.js:20:19)
[ERROR]     at new PluginWebpackConfig (/Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget/node_modules/graylog-web-plugin/lib/PluginWebpackConfig.js:25:28)
[ERROR]     at Object.<anonymous> (/Users/edmundoa/Workspace/graylog/project/master/graylog-plugin-map-widget/webpack.config.js:5:18)
[ERROR]     at Module._compile (module.js:570:32)
[ERROR]     at Object.Module._extensions..js (module.js:579:10)
"eslint": "^3.16.1",
"eslint-config-airbnb": "^14.1.0",
"eslint": "^4.3.0",
"eslint-config-airbnb": "^15.1.0",

This comment has been minimized.

@edmundoa

edmundoa Aug 4, 2017

Member

Do you know what changed there? I couldn't find any meaningful changelog. I only see more and more red in my editor, whenever I open a file, which is starting to be annoying for me :(

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 4, 2017

After disabling plugins I didn't notice anything odd, so I guess we just need to adapt the plugin configuration for these changes. In my opinion we should do PRs for that and merge everything once it's ready. Otherwise the build is going to be broken for a while and that's far from optimal.

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Aug 7, 2017

@edmundoa: Did you try the graylog-project build with a clean setup (including cleaning all node_modules dirs)? As you can see from the automated graylog-project build it should work for a clean, full build.

dennisoelkers added some commits Jul 26, 2017

@dennisoelkers dennisoelkers force-pushed the web-dependency-updates branch from 14507ae to 4164df4 Aug 7, 2017

@edmundoa

@dennisoelkers I'm quite sure I tried cleaning all node modules when it didn't work the first time. In any case today I tried again a couple times (after a local rebase) and it worked without any issues 🤷‍♀️

Could you please update the vendor-module-ids.json file reflecting the changes in here? Other than that I'm ready to merge.

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Aug 23, 2017

Updated the vendor module ids. Thanks! 👍

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit 80ca302 into master Aug 28, 2017

4 of 5 checks passed

graylog-project/pr Jenkins build graylog-project-pr-snapshot 406 has failed
Details
ci-web-linter Jenkins build graylog-pr-linter-check 1876 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@edmundoa edmundoa deleted the web-dependency-updates branch Aug 28, 2017

@edmundoa edmundoa modified the milestones: 2.4.0, 3.0.0 Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment