New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return NaN for non-present fields of FieldStatsResult #4046

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Aug 2, 2017

Description

Motivation and Context

Before this change, an ExtendedStatsAggregation could include an
arbitrary number of fields that are null. Assigning them a non-boxed
field type leads to an NPE and a 500 is being returned to the caller
when the result of a extended field stats widget is requested.

This change properly assigns a valid value for those fields, so a result
(albeit possibly containing NaN for one or more fields) is being
returned to the caller.

Fixes #4026, #4045

(cherry picked from commit 882727e)

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Return NaN for non-present fields of FieldStatsResult
Before this change, an ExtendedStatsAggregation could include an
arbitrary number of fields that are null. Assigning them a non-boxed
field type leads to an NPE and a 500 is being returned to the caller
when the result of a extended field stats widget is requested.

This change properly assigns a valid value for those fields, so a result
(albeit possibly containing NaN for one or more fields) is being
returned to the caller.

Fixes #4026

(cherry picked from commit 882727e)

@dennisoelkers dennisoelkers added this to the 2.3.1 milestone Aug 2, 2017

@dennisoelkers dennisoelkers requested a review from joschi Aug 2, 2017

@joschi

joschi approved these changes Aug 2, 2017

@joschi joschi self-assigned this Aug 2, 2017

@joschi joschi merged commit c1a96dc into 2.3 Aug 2, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1835 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 348 has succeeded
Details

@joschi joschi deleted the issue-4026-2.3 branch Aug 2, 2017

@joschi joschi referenced this pull request Aug 2, 2017

Closed

Alert check skipped, NPE #4045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment