New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Widget Labels to Widget Footer #4072

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@billmurrin
Contributor

billmurrin commented Aug 11, 2017

Move Widget time calculation and error labels to the bottom-left of the widget panel to make more room for the Widget Title.

Description

Modified the Widget, Widget Header, Widget Footer and related CSS to facilitate the movement of the time calculation and error label to the bottom-left of the widget. The label uses absolute positioning like the action buttons which are also located within the footer.

Motivation and Context

The PR implements the change requested in Issue #4052

How Has This Been Tested?

Modified source code, started local web development environment (npm start) with hot-loading to test changes.

Screenshots (if appropriate):

Before
Before Image

After
After Image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@lennartkoopmann

This comment has been minimized.

Member

lennartkoopmann commented Aug 11, 2017

Love the idea!

@bernd bernd self-assigned this Aug 11, 2017

@bernd bernd added the improvement label Aug 11, 2017

@bernd bernd removed their assignment Aug 25, 2017

@edmundoa edmundoa self-assigned this Sep 11, 2017

@edmundoa edmundoa self-requested a review Sep 11, 2017

@edmundoa

Hi,

I think the change makes sense and it also works fine, so I'll merge it into master.

Thank you for your contribution! 👍

@edmundoa edmundoa merged commit 9508526 into Graylog2:master Sep 14, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1857 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 386 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment