Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding user specified HTTP headers to HTTP JSON data adapter. #4094
Motivation and Context
This allows the user to specify and manage HTTP headers for data
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Aug 16, 2017
referenced this pull request
Aug 21, 2017
The current implementation doesn't allow overriding the
User-Agent HTTP request headers when defining them as additional HTTP headers.
Instead of replacing the original headers, it adds an additional one.
Example with custom
Accept: text/plain HTTP request header:
GET / HTTP/1.1 User-Agent: Graylog Lookup - https://www.graylog.org/ Accept: application/json Foo: Bar Accept: text/plain Host: 127.0.0.1:12345 Connection: Keep-Alive Accept-Encoding: gzip
The implementation should either replace the original headers or don't allow to override the
User-Agent HTTP request headers in the "HTTP Headers" section.
Another minor nitpick:
This should be properly documented.