New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lenient delimiter based frame decoder in TcpTransport #4106

Merged
merged 2 commits into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 23, 2017

In contrast to the standard DelimiterBasedFrameDecoder from Netty, the derivative LenientDelimiterBasedFrameDecoder emits the last bytes received on the channel
even if it doesn't end with the configured delimiter.

Fixes #4105

Use lenient delimiter based frame decoder in TcpTransport
In contrast to the standard `DelimiterBasedFrameDecoder` from Netty, the derivative
`LenientDelimiterBasedFrameDecoder` emits the last bytes received on the channel
even if it doesn't end with the configured delimiter.

Fixes #4105

@joschi joschi added this to the 2.4.0 milestone Aug 23, 2017

@joschi joschi added the bug label Aug 23, 2017

@bernd bernd self-assigned this Sep 26, 2017

@bernd

bernd approved these changes Sep 26, 2017

Tested with several delimiters, seems to work fine. LGTM 👍

@bernd bernd merged commit 78c777d into master Sep 26, 2017

3 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1878 has succeeded
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 408 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the issue-4105 branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment