New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting the maximum HTTP request headers size in JerseyService #4128

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@joschi
Contributor

joschi commented Sep 6, 2017

The configuration settings rest_max_initial_line_length and web_max_initial_line_length were incorrectly used in JerseyService to specify the maximum size of HTTP request headers.

The correct configuration settings to use are rest_max_header_size and web_max_header_size.

Since there are no equivalent settings in Grizzly (as opposed to Netty's HTTP handler, from which these settings have been carried over), the incorrectly used settings have been removed.

Fixes #4118
Refs #1613

Fix setting the maximum HTTP request headers size in JerseyService
The configuration settings `rest_max_initial_line_length` and `web_max_initial_line_length`
were incorrectly used in `JerseyService` to specify the maximum size of HTTP request headers.

The correct configuration settings to use are `rest_max_header_size` and `web_max_header_size`.

Since there are no equivalent settings in Grizzly (as opposed to Netty's HTTP handler, from
which these settings have been carried over), the incorrectly used settings have been removed.

Fixes #4118
Refs #1613

@dennisoelkers dennisoelkers merged commit 73e87d1 into master Sep 11, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1888 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 419 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the issue-4118 branch Sep 11, 2017

@bernd bernd added the backport label Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment