New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #4134

Merged
merged 21 commits into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Sep 8, 2017

@joschi joschi added this to the 2.4.0 milestone Sep 8, 2017

@joschi joschi force-pushed the dependency-updates branch from 263031d to 80d9952 Sep 20, 2017

@bernd bernd self-assigned this Sep 20, 2017

@@ -37,14 +37,14 @@
import java.util.Map;
public class AlarmCallbackConfigurationServiceImpl implements AlarmCallbackConfigurationService {
private final JacksonDBCollection<AlarmCallbackConfigurationImpl, String> coll;
private final JacksonDBCollection<AlarmCallbackConfigurationImpl, ObjectId> coll;

This comment has been minimized.

@bernd

bernd Sep 20, 2017

Member

Are these String vs ObjectId changes related to the MongoDB driver update or what is the intention behind those?

This comment has been minimized.

@joschi

joschi Sep 25, 2017

Contributor

Without these changes, MongoJack fails with a ClassCastException in the WriteResult#getSavedId() method.

Similar to mongojack/mongojack#8.

I've reverted updating the MongoDB Java driver dependency for now.

This comment has been minimized.

@joschi

joschi Sep 25, 2017

Contributor

Scratch that. The problem seems to be Jackson 2.9.x.

I've reverted the commit updating Jackson and added back the commit updating the MongoDB Java driver.

joschi added some commits Sep 7, 2017

@joschi joschi force-pushed the dependency-updates branch 2 times, most recently from f4ae392 to 73d35b6 Sep 22, 2017

@joschi joschi force-pushed the dependency-updates branch from 73d35b6 to 7fe2ebe Sep 25, 2017

joschi added some commits Sep 25, 2017

Revert "Upgrade to Jackson 2.9.1"
This reverts commit 8e7b0ed.
@bernd

bernd approved these changes Sep 25, 2017

I only did some light testing but this doesn't seem to break anything as far as I can see.

@bernd bernd merged commit fb91299 into master Sep 25, 2017

4 of 5 checks passed

graylog-project/pr Jenkins build graylog-project-pr-snapshot 498 has failed
Details
ci-web-linter Jenkins build graylog-pr-linter-check 1942 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the dependency-updates branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment