Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling of "facility" field in GELF Output #4141

Merged
merged 1 commit into from Sep 18, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Sep 12, 2017

Since "facility" is not a reserved field (as of GELF 1.1), it shouldn't be handled in a special way.

This change set removes casting the "facility" field to a string and uses it as-is in the generated GELF message.

Fixes #4140

Since "facility" is not a reserved field (as of GELF 1.1), it shouldn't be handled
in a special way.

This change set removes casting the "facility" field to a string and uses it as-is
in the generated GELF message.

Fixes #4140
@joschi joschi added this to the 2.4.0 milestone Sep 12, 2017
@bernd bernd self-assigned this Sep 18, 2017
@bernd
bernd approved these changes Sep 18, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 6271976 into master Sep 18, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1897 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 429 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the issue-4140 branch Sep 18, 2017
@bernd bernd added the backport label Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants