Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "deprecated" Counts API with Multi Search with size=0 #4147

Merged
merged 3 commits into from Sep 19, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Sep 14, 2017

The Elasticsearch Count API doesn't allow setting the indices in the HTTP request body
and suffers from the issue that users with a large number of indices run into the default
HTTP header size limit of Elasticsearch (4 KB).

This change set replaces the (kind of) deprecated Counts API with a regular search with
size=0 issued via the Elasticsearch Multi Search API which allows specifiying the list
of indices in the request body.

Fixes #4136
Refs elastic/elasticsearch#13928

The Elasticsearch Count API doesn't allow setting the indices in the HTTP request body
and suffers from the issue that users with a large number of indices run into the default
HTTP header size limit of Elasticsearch (4 KB).

This change set replaces the (kind of) deprecated Counts API with a regular search with
size=0 issued via the Elasticsearch Multi Search API which allows specifiying the list
of indices in the request body.

Fixes #4136
Refs elastic/elasticsearch#13928
@bernd
bernd approved these changes Sep 19, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd self-assigned this Sep 19, 2017
@bernd bernd merged commit 302cee2 into master Sep 19, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1901 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 433 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the issue-4136 branch Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants