Improving widget/grid stability and prop consistency #4160
Also namespace the renderlet calback in D3Utils.tooltipRenderlet() to avoid conflicts with other callbacks.
Also rename a variable and remove static attributes from updating.
edmundoa merged commit
Sep 29, 2017
5 checks passed
5 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 1950 has succeededDetails
continuous-integration/travis-ci/pr The Travis CI build passedDetails
continuous-integration/travis-ci/push The Travis CI build passedDetails
graylog-project/pr Jenkins build graylog-project-pr-snapshot 510 has succeededDetails
license/cla Contributor License Agreement is signed.Details
edmundoa added a commit that referenced this pull request
Sep 29, 2017
* Fix linting issues in ReactGridContainer * Add prop to set row height in ReactGridContainer * Add extra flag to resize in ReactGridContainer Now it is possible to restrict widget resize, even if ReactGridContainer is not locked. * Set default positioning values This makes ReactGridContainer work even if not all position properties are set. * Improve numeric visualization styling - Use flexbox to make styling a bit simpler - Move styling away from global stylesheet * Defining propTypes, passing through disableSurroundingSearch prop. * Passing page size and current page. * Allowing to pass sort order, title & limit to quick values vis. * Using count dimension to fix limiting in QuickValuesVisualization. * Using actual limit parameter instead of (removed) constant. * Making axis labels configurable for histogram. * Using updated computation time range when normalizing data. * Allowing to pass custom title to stacked chart series. * Allow disabling circles on stacked graphs. * Use new props when formatting data for stacked graphs. * Check if data points are not empty before deducing custom tick values. * Using next props to rerender graph upon props update. * Add an optional threshold line in the GraphVisualization component Also namespace the renderlet calback in D3Utils.tooltipRenderlet() to avoid conflicts with other callbacks. * Fix threshold updating in GraphVisualization * Update threshold dot title on update in GraphVisualization Also rename a variable and remove static attributes from updating. * Use a dashed line for the threshold That way it doesn't look like another regular value. * Removing unused import. * Removing unused constant. * Escaping threshold tooltip. * Separating pie chart slice and data table row limits. (cherry picked from commit ac4c9b0)
bernd added a commit that referenced this pull request
Oct 5, 2017
Fixes an issue when no "pageSize" prop is provided. This broke in #4160.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.