New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert filter condition to fix numeric field errors #4168

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Sep 21, 2017

This broke in #4149

@bernd bernd added this to the 2.4.0 milestone Sep 21, 2017

@bernd bernd requested a review from joschi Sep 21, 2017

@@ -579,7 +579,7 @@ public HistogramResult fieldHistogram(String query,
if (failedShards > 0) {
final List<String> errors = StreamSupport.stream(shards.path("failures").spliterator(), false)
.map(failure -> failure.path("reason").path("reason").asText())
.filter(String::isEmpty)
.filter(s -> !s.isEmpty())

This comment has been minimized.

@joschi

joschi Sep 21, 2017

Contributor

A test for this would be great.

@joschi

joschi approved these changes Sep 21, 2017

@joschi joschi merged commit a3b8c6d into master Sep 21, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1931 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 484 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@joschi joschi deleted the fix-check-for-failed-shards branch Sep 21, 2017

@joschi joschi self-assigned this Sep 21, 2017

@joschi joschi added the bug label Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment