New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling ESLint indent rule for JSX elements. #4173

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Sep 21, 2017

Due to conflicting views between ESLint and us on how JSX props should be indented, the indent rule is now disabled for JSX attributes.

It will be reenabled when there is the first option for JSX prop indentation. Otherwise a different, JSX-specific indentation rule supporting this will be put in place instead.

Disabling ESLint indent rule for JSX elements.
Due to conflicting views between ESLint and us on how JSX elements
should be indented, the `indent` rule is now disabled for JSX elements.

It will be reenabled when there is the `first` option for JSX prop
indentation. Otherwise a different, JSX-specific indentation rule
supporting this will be put in place instead.

@edmundoa edmundoa self-assigned this Sep 22, 2017

@edmundoa

This still has the side effect of not warning when a prop is not in line with others, but I think it's a good compromise until there's some good solution for it. So I give my 👍

@edmundoa edmundoa merged commit 67d046f into master Sep 22, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1934 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 489 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@edmundoa edmundoa deleted the disable-jsx-eslint-indentation-checks branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment