Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field charts for non-numeric fields #4182

Merged
merged 3 commits into from Sep 27, 2017
Merged

Field charts for non-numeric fields #4182

merged 3 commits into from Sep 27, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Sep 26, 2017

Up until now, trying to generate a field chart on a non-numeric value failed, as the server did only try to calculate statistical aggregations for the field and that is not possible. Anyway, we could still calculate the total and cardinality functions for those fields, as we do in the statistics analyzer.

This PR changes how we treat non-numeric field charts, enabling users to generate graphs for cardinality and total. It is as well possible to stack them to other field charts, and add them to dashboards, just as with any other field graphs.

Implements #4083.

edmundoa added 3 commits Sep 26, 2017
It is possible to calculate count and cardinality histograms for
non-numeric fields. Now we do that instead of returning an error.
That is available both in numeric and non-numeric fields.
As in the search page, retry without statistical aggregation if a field
is non-numeric.
@edmundoa edmundoa added this to the 2.4.0 milestone Sep 26, 2017
@edmundoa edmundoa changed the title Feature 4083 Field charts for non-numeric fields Sep 26, 2017
@bernd bernd self-assigned this Sep 26, 2017
@bernd
bernd approved these changes Sep 27, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 82359e9 into master Sep 27, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1946 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 505 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the feature-4083 branch Sep 27, 2017
@bernd bernd mentioned this pull request Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants