New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify action components of all field analyzers #4219

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@lennartkoopmann
Member

lennartkoopmann commented Oct 7, 2017

This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

  • The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close icon makes it stand out more and also saves real-estate. A margin to the left helps to identify it quickly and avoids accidental pressing of it.
  • The "Add to dashboard" button has the same and less intrusive button across all widgets now.
  • The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.

Important: There is a second PR in the map widget repository that should be merged after this one to keep UI consistency: Graylog2/graylog-plugin-map-widget#56

Screenshots:

screen shot 2017-10-06 at 9 19 48 pm

screen shot 2017-10-06 at 9 20 16 pm

screen shot 2017-10-06 at 9 21 15 pm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
Unify action components of all field analyzers
This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.

Note that there will be a separate commit and PR for the map widget, which is in a separate repository. These changes should be merged one after the other to keep UI consistency.

@lennartkoopmann lennartkoopmann added this to the 2.4.0 milestone Oct 7, 2017

@lennartkoopmann lennartkoopmann requested a review from edmundoa Oct 7, 2017

lennartkoopmann added a commit to Graylog2/graylog-plugin-map-widget that referenced this pull request Oct 7, 2017

Unify action components of all field analyzers
This commit is a part of Graylog2/graylog2-server#4219, where the other field analyzer widgets were adressed.

This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.
@joschi

joschi approved these changes Oct 10, 2017

@joschi joschi merged commit a99ea1d into master Oct 10, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1990 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 578 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@joschi joschi deleted the unify-field-analyzer-actions branch Oct 10, 2017

@joschi joschi self-assigned this Oct 10, 2017

@wafflebot wafflebot bot removed the ready-for-review label Oct 10, 2017

joschi added a commit to Graylog2/graylog-plugin-map-widget that referenced this pull request Oct 10, 2017

Unify action components of all field analyzers (#56)
This commit is a part of Graylog2/graylog2-server#4219, where the other field analyzer widgets were adressed.

This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.

@joschi joschi modified the milestones: 2.4.0, 3.0.0 Oct 10, 2017

joschi added a commit that referenced this pull request Oct 10, 2017

Unify action components of all field analyzers (#4219)
This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.

(cherry picked from commit a99ea1d)

joschi added a commit to Graylog2/graylog-plugin-map-widget that referenced this pull request Oct 10, 2017

Unify action components of all field analyzers (#56)
This commit is a part of Graylog2/graylog2-server#4219, where the other field analyzer widgets were adressed.

This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.

(cherry picked from commit 79c3b67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment