Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "alt key submits" functionality from histogram #4243

Merged
merged 1 commit into from Oct 13, 2017
Merged

remove "alt key submits" functionality from histogram #4243

merged 1 commit into from Oct 13, 2017

Conversation

@kroepke
Copy link
Member

@kroepke kroepke commented Oct 13, 2017

the old jquery code could submit the search form directly when the alt key was pressed.
ever since moving to react this was broken because the code cannot submit the form anymore.
this removes the useless code to avoid a javascript error

fixes #4214

the old jquery code could submit the search form directly when the alt key was pressed.
ever since moving to react this was broken because the code cannot submit the form anymore.
this removes the useless code to avoid a javascript error

fixes #4214
@kroepke kroepke added this to the 3.0.0 milestone Oct 13, 2017
@ghost ghost assigned kroepke Oct 13, 2017
@ghost ghost added the in progress label Oct 13, 2017
@joschi
joschi approved these changes Oct 13, 2017
@joschi joschi merged commit b8fec02 into master Oct 13, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2003 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 596 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@joschi joschi deleted the issue-4214 branch Oct 13, 2017
@ghost ghost removed the ready-for-review label Oct 13, 2017
joschi pushed a commit that referenced this pull request Oct 13, 2017
The old jQuery code could submit the search form directly when the alt key was pressed.
Ever since moving to react this was broken because the code cannot submit the form anymore.

This commit removes the useless code to avoid a JavaScript error

Fixes #4214

(cherry picked from commit b8fec02)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants