New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll queries using Searches#scroll() #4269

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Oct 19, 2017

Scroll queries were broken for a number of different reasons:

Due to the default HTTP request length limit of Elasticsearch, Search#scroll() resolves the affected index sets and uses the index wildcards instead of separate index names.

Fixes #4190
Refs #4262
(cherry picked from commit 7239f15)

Fix scroll queries using Searches#scroll() (#4262)
Scroll queries were broken for a number of different reasons:

* The fork of Jest used by Graylog had a bug regarding scroll queries (searchbox-io/Jest#489, searchbox-io/Jest#491)
* The Elasticsearch Multi Search API doesn't support scroll queries (elastic/elasticsearch#18454)

Due to the default HTTP request length limit of Elasticsearch, `Search#scroll()` resolves the affected index sets
and uses the index wildcards instead of separate index names.

Fixes #4190

(cherry picked from commit 7239f15)

@joschi joschi added this to the 2.3.2 milestone Oct 19, 2017

@joschi joschi requested a review from bernd Oct 19, 2017

@bernd

bernd approved these changes Oct 19, 2017

@bernd bernd merged commit 9aceff2 into 2.3 Oct 19, 2017

2 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 625 is running
Details
ci-web-linter Jenkins build graylog-pr-linter-check 2019 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the issue-4190-2.3 branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment