Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in unified analyzer menus #4280

Merged
merged 2 commits into from Oct 24, 2017
Merged

Improvements in unified analyzer menus #4280

merged 2 commits into from Oct 24, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Oct 24, 2017

This PR fixes two issues with the new unified analyzer menus:

  • Make menus look grouped, fixing issue #4230
  • Set pullRight option to menus, so that they open to the left side, avoiding cropping menus too close to the window edge
edmundoa added 2 commits Oct 24, 2017
Dropdown menus on the unified analyzer menus open currently to the right, but
they are very close to the edge of the window and will be cropped. This
commit changes that by opening menus to the left.
@edmundoa edmundoa added this to the 3.0.0 milestone Oct 24, 2017
@ghost ghost assigned edmundoa Oct 24, 2017
@edmundoa edmundoa removed their assignment Oct 24, 2017
edmundoa added a commit to Graylog2/graylog-plugin-map-widget that referenced this pull request Oct 24, 2017
joschi added a commit to Graylog2/graylog-plugin-map-widget that referenced this pull request Oct 24, 2017
@bernd bernd self-assigned this Oct 24, 2017
joschi pushed a commit to Graylog2/graylog-plugin-map-widget that referenced this pull request Oct 24, 2017
@bernd
bernd approved these changes Oct 24, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit f09054a into master Oct 24, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2026 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 641 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the issue-4230 branch Oct 24, 2017
@ghost ghost removed the ready-for-review label Oct 24, 2017
bernd added a commit that referenced this pull request Oct 24, 2017
* Fix styling of unified analyzer buttons

Fixes #4230

* Open analyzer menus to the left

Dropdown menus on the unified analyzer menus open currently to the right, but
they are very close to the edge of the window and will be cropped. This
commit changes that by opening menus to the left.

(cherry picked from commit f09054a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants