Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data that is shown by the QuickValues histogram #4312

Merged
merged 5 commits into from Nov 3, 2017
Merged

Conversation

@bernd
Copy link
Member

@bernd bernd commented Nov 2, 2017

Previously we showed the top/bottom N terms for every bucket in the histogram. That was hard to visualize because every bucket could contain completely different terms.

Now we changed the visualization to show only the top/bottom N terms from the regular QuickValues widget projected over time.

Fixes #4291

Note: This needs to be merged into 2.4 as well

bernd added 4 commits Nov 2, 2017
Create functions that do not mutate the global query string and let the
old functions use them.

This allows us to reuse the query manipulation functions without
changing the global query.
Previously we showed the top/bottom N terms for every bucket in the
histogram. That was hard to visualize because every bucket could contain
completely different terms.

Now we changed the visualization to show *only* the top/bottom N terms from
the regular QuickValues widget projected over time.

Fixes #4291
@bernd bernd added this to the 2.4.0 milestone Nov 2, 2017
@bernd bernd requested a review from edmundoa Nov 2, 2017
@ghost ghost assigned bernd Nov 2, 2017
@bernd bernd removed their assignment Nov 2, 2017
@edmundoa edmundoa self-assigned this Nov 2, 2017
@ghost ghost assigned bernd Nov 3, 2017
Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit 4309698 into master Nov 3, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2043 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 668 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-4291 branch Nov 3, 2017
@ghost ghost removed the ready-for-review label Nov 3, 2017
edmundoa added a commit that referenced this pull request Nov 3, 2017
* Store a set of all terms in the terms histogram result

* Refactor SearchStore query manipulation functions

Create functions that do not mutate the global query string and let the
old functions use them.

This allows us to reuse the query manipulation functions without
changing the global query.

* Show regular QuickValues widget when changing the field

* Change data that is shown by the QuickValues histogram

Previously we showed the top/bottom N terms for every bucket in the
histogram. That was hard to visualize because every bucket could contain
completely different terms.

Now we changed the visualization to show *only* the top/bottom N terms from
the regular QuickValues widget projected over time.

Fixes #4291

* Improve QuickValues visualization for stacked values

Fixes #4309

(cherry picked from commit 4309698)
@bernd bernd mentioned this pull request Nov 10, 2017
2 of 2 tasks complete
bernd added a commit that referenced this pull request Nov 13, 2017
This ensures that we also use a more visible separator when using
stacked fields.

Refs #4312
Fixes #4336
edmundoa added a commit that referenced this pull request Nov 14, 2017
* Return "terms_mapping" in QuickValuesWidgetStrategy

This ensures that we also use a more visible separator when using
stacked fields.

Refs #4312
Fixes #4336

* Use a darker color for the QuickValues field separator

The previous color was too bright.

Fixes #4336
edmundoa added a commit that referenced this pull request Nov 14, 2017
* Return "terms_mapping" in QuickValuesWidgetStrategy

This ensures that we also use a more visible separator when using
stacked fields.

Refs #4312
Fixes #4336

* Use a darker color for the QuickValues field separator

The previous color was too bright.

Fixes #4336

(cherry picked from commit 9b4a5f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants