New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading indicator when reloading field chart data #4319

Merged
merged 2 commits into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Nov 6, 2017

This PR displays a loading spinner while we fetch data to update a field chart. This will be visible when the search is updated, a new statistical function is selected, and when the chart resolution changes.

Fixes #4295 and should be cherry-picked into 2.4.

edmundoa added some commits Nov 6, 2017

Show spinner when updating field charts
Display a spinner when a field chart is updated, its statistical
function changes, or the resolution changes. In that way, the user can
receive some feedback while the graph data is loading.

Fixes #4295

@edmundoa edmundoa added this to the 2.4.0 milestone Nov 6, 2017

@edmundoa edmundoa removed their assignment Nov 6, 2017

@bernd bernd self-assigned this Nov 7, 2017

@bernd

bernd approved these changes Nov 7, 2017

LGTM 👍

@bernd bernd merged commit 816f8f8 into master Nov 7, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci-web-linter Jenkins build graylog-pr-linter-check 2044 has succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 669 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the issue-4295 branch Nov 7, 2017

@wafflebot wafflebot bot removed the ready-for-review label Nov 7, 2017

bernd added a commit that referenced this pull request Nov 7, 2017

Show loading indicator when reloading field chart data (#4319)
* Replace string ref with function

* Show spinner when updating field charts

Display a spinner when a field chart is updated, its statistical
function changes, or the resolution changes. In that way, the user can
receive some feedback while the graph data is loading.

Fixes #4295

(cherry picked from commit 816f8f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment