Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show feedback on create widget modal #4320

Merged
merged 1 commit into from Nov 7, 2017
Merged

Show feedback on create widget modal #4320

merged 1 commit into from Nov 7, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Nov 6, 2017

Disable button and change the submit button text while we create the new widget. Reset the state once the promise is fulfilled or rejected.

Fixes #4318 and should be cherry-picked into 2.4.

Disable button and change the submit button text while we create
the new widget. Reset the state once the promise is fulfilled or
rejected.

Fixes #4318
@edmundoa edmundoa added this to the 2.4.0 milestone Nov 6, 2017
@ghost ghost assigned edmundoa Nov 6, 2017
@edmundoa edmundoa removed their assignment Nov 6, 2017
@bernd bernd self-assigned this Nov 7, 2017
@bernd
bernd approved these changes Nov 7, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 28bbf2b into master Nov 7, 2017
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci-web-linter Jenkins build graylog-pr-linter-check 2045 has succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 670 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ghost ghost removed the ready-for-review label Nov 7, 2017
@bernd bernd deleted the issue-4318 branch Nov 7, 2017
bernd added a commit that referenced this pull request Nov 7, 2017
Disable button and change the submit button text while we create
the new widget. Reset the state once the promise is fulfilled or
rejected.

Fixes #4318

(cherry picked from commit 28bbf2b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.