Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QuickValues term separator rendering #4343

Merged
merged 2 commits into from Nov 14, 2017
Merged

Fix QuickValues term separator rendering #4343

merged 2 commits into from Nov 14, 2017

Conversation

@bernd
Copy link
Member

@bernd bernd commented Nov 13, 2017

  • Return "terms_mapping" in QuickValuesWidgetStrategy. This ensures that we also use a more visible separator when using stacked fields.
  • Use a darker color for the QuickValues field separator. The previous one was too bright.

Fixes #4336

Note: This needs to be cherry-picked into 2.4 as well

bernd added 2 commits Nov 13, 2017
This ensures that we also use a more visible separator when using
stacked fields.

Refs #4312
Fixes #4336
The previous color was too bright.

Fixes #4336
@bernd bernd added this to the 2.4.0 milestone Nov 13, 2017
@ghost ghost assigned bernd Nov 13, 2017
@bernd bernd removed their assignment Nov 13, 2017
@edmundoa edmundoa self-assigned this Nov 14, 2017
Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit 9b4a5f2 into master Nov 14, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2066 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 695 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-4336 branch Nov 14, 2017
edmundoa added a commit that referenced this pull request Nov 14, 2017
* Return "terms_mapping" in QuickValuesWidgetStrategy

This ensures that we also use a more visible separator when using
stacked fields.

Refs #4312
Fixes #4336

* Use a darker color for the QuickValues field separator

The previous color was too bright.

Fixes #4336

(cherry picked from commit 9b4a5f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants