Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change edit auth providers config button #4347

Merged
merged 1 commit into from Nov 14, 2017
Merged

Change edit auth providers config button #4347

merged 1 commit into from Nov 14, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Nov 14, 2017

Update in this screen feels like there will be some configuration change happening once the button is pressed, but we use that button to open a modal where the user can actually change the configuration. I found it a bit confusing myself, and thought that "edit" would be more appropriate in this case.

Before:
before

After:
after

Update in this screen feels like there will be some configuration change
happening, but we use that button to open a modal where the user can
actually change the configuration. I found it a bit confusing myself,
and thought that "edit" would be more appropriate in this case.
@edmundoa edmundoa added this to the 3.0.0 milestone Nov 14, 2017
@bernd
bernd approved these changes Nov 14, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd self-assigned this Nov 14, 2017
@bernd bernd merged commit b7c4c21 into master Nov 14, 2017
2 of 5 checks passed
2 of 5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2067 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 696 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ghost ghost removed the ready-for-review label Nov 14, 2017
@bernd bernd deleted the auth-providers-button branch Nov 14, 2017
bernd added a commit that referenced this pull request Nov 14, 2017
Update in this screen feels like there will be some configuration change
happening, but we use that button to open a modal where the user can
actually change the configuration. I found it a bit confusing myself,
and thought that "edit" would be more appropriate in this case.

(cherry picked from commit b7c4c21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants