Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing the default index set from the UI #4377

Merged
merged 3 commits into from Nov 30, 2017
Merged

Fix changing the default index set from the UI #4377

merged 3 commits into from Nov 30, 2017

Conversation

@bernd
Copy link
Member

@bernd bernd commented Nov 28, 2017

  • Do not try to stop event propagation in MenuItem callback functions
  • Fix eslint errors
  • Let _formatStatsString handle undefined global stats

Fixes #4376

Note: This needs to be cherry-picked into the 2.4 branch

bernd added 3 commits Nov 28, 2017
Makes changing the default index set from the UI work again.

Fixes #4376
This can happen when the stats have not been loaded yet.
@bernd bernd added this to the 3.0.0 milestone Nov 28, 2017
@bernd bernd requested a review from edmundoa Nov 28, 2017
@ghost ghost assigned bernd Nov 28, 2017
@bernd bernd removed their assignment Nov 28, 2017
@edmundoa edmundoa self-assigned this Nov 30, 2017
Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit 59e3607 into master Nov 30, 2017
4 of 5 checks passed
4 of 5 checks passed
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 741 has failed
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2093 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@ghost ghost removed the ready-for-review label Nov 30, 2017
@edmundoa edmundoa deleted the issue-4376 branch Nov 30, 2017
edmundoa added a commit that referenced this pull request Nov 30, 2017
* Do not try to stop event propagation in MenuItem callback functions

Makes changing the default index set from the UI work again.

Fixes #4376

* Fix eslint errors

* Let _formatStatsString handle undefined global stats

This can happen when the stats have not been loaded yet.

(cherry picked from commit 59e3607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants