Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show global notifications in 404 page #4389

Merged
merged 2 commits into from Dec 4, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Dec 1, 2017

Avoid displaying global notifications in the not found page. Other error pages do not need to be taken in consideration at this point, as they are rendered before react-router, and therefore do not render the global notifications component.

@edmundoa edmundoa added this to the 2.4.0 milestone Dec 1, 2017
@ghost ghost assigned edmundoa Dec 1, 2017
Avoid displaying global notifications in not found page. So far other
error pages will not be affected, as they are rendered before
react-router is used.
@edmundoa edmundoa force-pushed the remove-404-global-notification branch from 95b1737 to f4ea9e5 Dec 1, 2017
@edmundoa edmundoa removed their assignment Dec 1, 2017
@edmundoa edmundoa force-pushed the remove-404-global-notification branch from f4ea9e5 to 9c3845a Dec 1, 2017
@ghost ghost assigned edmundoa Dec 1, 2017
@edmundoa edmundoa removed their assignment Dec 1, 2017
@kroepke
kroepke approved these changes Dec 4, 2017
@kroepke kroepke merged commit a58f56f into master Dec 4, 2017
5 checks passed
5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2105 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 768 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the remove-404-global-notification branch Dec 4, 2017
@ghost ghost removed the ready-for-review label Dec 4, 2017
edmundoa added a commit that referenced this pull request Dec 4, 2017
* Do not show global notifications in error pages

Avoid displaying global notifications in not found page. So far other
error pages will not be affected, as they are rendered before
react-router is used.

* Fix linter errors

(cherry picked from commit a58f56f)
bernd added a commit that referenced this pull request Dec 4, 2017
* Do not show global notifications in error pages

Avoid displaying global notifications in not found page. So far other
error pages will not be affected, as they are rendered before
react-router is used.

* Fix linter errors

(cherry picked from commit a58f56f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants