New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show global notifications in 404 page (#4389) #4393

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Dec 4, 2017

Rebase of #4389 against 2.4.

Do not show global notifications in 404 page (#4389)
* Do not show global notifications in error pages

Avoid displaying global notifications in not found page. So far other
error pages will not be affected, as they are rendered before
react-router is used.

* Fix linter errors

(cherry picked from commit a58f56f)

@edmundoa edmundoa added this to the 2.4.0 milestone Dec 4, 2017

@edmundoa edmundoa requested a review from kroepke Dec 4, 2017

@edmundoa edmundoa removed their assignment Dec 4, 2017

@bernd

bernd approved these changes Dec 4, 2017

@bernd bernd merged commit 846449b into 2.4 Dec 4, 2017

1 of 5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2107 has failed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 775 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the pr-4389-2.4 branch Dec 4, 2017

@wafflebot wafflebot bot removed the ready-for-review label Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment