Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTTPJSONPath lookup table data adapter UI #4406

Merged
merged 3 commits into from Dec 12, 2017

Conversation

@bernd
Copy link
Member

@bernd bernd commented Dec 8, 2017

This replaces the custom UI to set HTTP headers in HTTPJSONPathAdapterFieldSet.jsx with the existing KeyValueList component.

Note: This needs to be cherry-picked into 2.4 once merged

Before:

image

After:

image

@bernd bernd added this to the 3.0.0 milestone Dec 8, 2017
@bernd bernd requested a review from edmundoa Dec 8, 2017
@ghost ghost assigned bernd Dec 8, 2017
@bernd bernd removed their assignment Dec 8, 2017
@edmundoa edmundoa self-assigned this Dec 8, 2017
@bernd bernd force-pushed the improve-httpjsonpath-adapter-ui branch from d30d7e8 to b5eb0c7 Dec 8, 2017
@ghost ghost assigned bernd Dec 8, 2017
@bernd bernd removed their assignment Dec 8, 2017
Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit 5548e36 into master Dec 12, 2017
4 of 5 checks passed
4 of 5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2121 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 797 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@ghost ghost removed the ready-for-review label Dec 12, 2017
@edmundoa edmundoa deleted the improve-httpjsonpath-adapter-ui branch Dec 12, 2017
edmundoa added a commit that referenced this pull request Dec 12, 2017
* Fix KeyValueTable styling when embedded in FormGroup components

* Use KeyValueList instead of custom form for HTTP headers

* Use KeyValueTable in HTTPJSONPathAdapterSummary as well

(cherry picked from commit 5548e36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants