New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check node id file permissions as part of parameter validation #4417

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Dec 13, 2017

check node id file permissions as part of parameter validation, instead of failing during injection

doing IO during object construction is brittle and leads to unintelligible error messages

fixes #4410

check node id file permissions as part of parameter validation, inste…
…ad of failing during injection

doing IO during object construction is brittle and leads to unintelligible error messages

@kroepke kroepke added this to the 3.0.0 milestone Dec 13, 2017

@kroepke

This comment has been minimized.

Member

kroepke commented Dec 13, 2017

Could be backported to 2.4 if someone feels it is important enough.

@kroepke

This comment has been minimized.

Member

kroepke commented Dec 14, 2017

I didn't use the built-in File validator classes, because unfortunately the config parameter is a string, not a file and I didn't want to make too many changes for 2.4.

@kroepke kroepke requested a review from joschi Dec 14, 2017

@kroepke kroepke modified the milestones: 3.0.0, 2.4.0 Dec 14, 2017

@kroepke kroepke removed the request for review from joschi Dec 15, 2017

@edmundoa edmundoa self-requested a review Dec 15, 2017

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit 5a0297a into master Dec 15, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2126 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 806 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the ready-for-review label Dec 15, 2017

@edmundoa edmundoa deleted the issue-4410 branch Dec 15, 2017

kroepke added a commit that referenced this pull request Dec 15, 2017

check node id file permissions as part of parameter validation, inste…
…ad of failing during injection (#4417)

doing IO during object construction is brittle and leads to unintelligible error messages

(cherry picked from commit 5a0297a)

bernd added a commit that referenced this pull request Dec 20, 2017

Revert "check node id file permissions as part of parameter validatio…
…n, instead of failing during injection (#4417)"

This reverts commit 204a624.

kroepke added a commit that referenced this pull request Dec 20, 2017

Revert node-id file validations (#4433)
* Revert "fix node id file permission checks (#4428)"

This reverts commit b0b7b9b.

* Revert "check node id file permissions as part of parameter validation, instead of failing during injection (#4417)"

This reverts commit 204a624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment