New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pass custom renderers for key and value titles in histograms #4418

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Dec 13, 2017

the default renderers can now be replaced individually by setting props

used in TrafficGraphs to display nicer values

fixes #4395

allow to pass custom renderers for key and value titles in histograms
the default renderers can now be replaced individually by setting props

used in TrafficGraphs to display nicer values

fixes #4395

@kroepke kroepke added this to the 3.0.0 milestone Dec 13, 2017

@kroepke kroepke requested a review from edmundoa Dec 13, 2017

@kroepke

This comment has been minimized.

Member

kroepke commented Dec 13, 2017

Should be backported to 2.4 once merged

@edmundoa

LGTM 👍

@edmundoa edmundoa merged commit c73f55e into master Dec 14, 2017

4 of 5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2127 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 807 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@edmundoa edmundoa deleted the issue-4395 branch Dec 14, 2017

@wafflebot wafflebot bot removed the ready-for-review label Dec 14, 2017

edmundoa added a commit that referenced this pull request Dec 14, 2017

allow to pass custom renderers for key and value titles in histograms (
…#4418)

the default renderers can now be replaced individually by setting props

used in TrafficGraphs to display nicer values

fixes #4395

(cherry picked from commit c73f55e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment