New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node id file permission checks #4428

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Dec 18, 2017

server start would fail if the node id was non-empty, but not writable.
this is a valid scenario where the node id is frozen by making the file read-only

added tests for various scenarios

fixes #4427

fix node id file permission checks
server start would fail if the node id was non-empty, but not writable.
this is a valid scenario where the node id is frozen by making the file read-only

added tests for various scenarios

fixes #4427

@kroepke kroepke added this to the 2.4.0 milestone Dec 18, 2017

@kroepke kroepke requested a review from bernd Dec 18, 2017

@bernd bernd assigned bernd and unassigned kroepke Dec 18, 2017

@bernd

bernd approved these changes Dec 18, 2017

LGTM 👍

@bernd bernd merged commit 3de61c0 into master Dec 18, 2017

5 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 2137 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 838 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the ready-for-review label Dec 18, 2017

@bernd bernd deleted the issue-4427 branch Dec 18, 2017

bernd added a commit that referenced this pull request Dec 18, 2017

fix node id file permission checks (#4428)
server start would fail if the node id was non-empty, but not writable.
this is a valid scenario where the node id is frozen by making the file read-only

added tests for various scenarios

fixes #4427

(cherry picked from commit 3de61c0)

bernd added a commit that referenced this pull request Dec 20, 2017

kroepke added a commit that referenced this pull request Dec 20, 2017

Revert node-id file validations (#4433)
* Revert "fix node id file permission checks (#4428)"

This reverts commit b0b7b9b.

* Revert "check node id file permissions as part of parameter validation, instead of failing during injection (#4417)"

This reverts commit 204a624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment