Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create npm-shrinkwrap.json files for the 2.4.0 release #4496

Merged
merged 2 commits into from Jan 19, 2018
Merged

Conversation

@bernd
Copy link
Member

@bernd bernd commented Jan 18, 2018

Due to a reflux peer dependency problem with react, we ran into an error
and couldn't create a shrinkwrap file for the 2.4.0 release in December.

We now ran into a compatibility problem with a plugin because of changed
dependencies and I tried to create a shrinkwrap file again. It worked
after manually modifying the react peer dependency in the installed
reflux module.

To make sure we have the correct dependency versions from the time of
the 2.4.0 release build, I used the Jenkins workspace directory - which
luckily still existed - to create the npm-shrinkwrap.json file.

@ghost ghost assigned bernd Jan 18, 2018
@ghost ghost added the in progress label Jan 18, 2018
@bernd bernd added this to the 2.4.1 milestone Jan 18, 2018
Copy link
Contributor

@joschi joschi left a comment

The Jenkins build job is failing due to the following error:

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.4:install-node-and-yarn (default-cli) on project graylog2-server: The parameters 'yarnVersion' for goal com.github.eirslett:frontend-maven-plugin:1.4:install-node-and-yarn are missing or invalid -> [Help 1]
@joschi joschi dismissed their stale review Jan 19, 2018

Jenkins build job is incompatible with 2.4 branch (which is still using npm instead of yarn)

@joschi
joschi approved these changes Jan 19, 2018
@joschi joschi merged commit 781d9f2 into 2.4 Jan 19, 2018
4 of 5 checks passed
4 of 5 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 2196 has failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 921 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@joschi joschi deleted the npm-shrinkwrap-2.4 branch Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants